Skip to content

rustdoc: use CSS overscroll-behavior instead of JavaScript#110165

Merged
bors merged 1 commit intorust-lang:masterfrom
notriddle:notriddle/overscroll-behavior
Apr 12, 2023
Merged

rustdoc: use CSS overscroll-behavior instead of JavaScript#110165
bors merged 1 commit intorust-lang:masterfrom
notriddle:notriddle/overscroll-behavior

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented Apr 10, 2023 •
edited
Loading

Fixes the desktop scrolling weirdness mentioned in #98775 (comment)

Preview: https://notriddle.com/rustdoc-demo-html-3/overscroll-behavior/issue_107918/index.html

As described in the MDN overscroll-behavior page:

  • The current Firefox ESR is 102, and the first Firefox version to support this feature is 59.
  • The current Chrome version 112, and the first version to support this is 63.
  • Edge is described as having a minor bug in none mode, but we use contain mode anyway, so it doesn't matter.
  • Safari 16, released September 2022, is the last browser to add this feature, and is also the oldest version we officially support.

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle notriddle force-pushed the notriddle/overscroll-behavior branch from ab9b4cd to 6da8cb1 Compare April 10, 2023 23:40
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 11, 2023

That's great, thanks!

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 11, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

📌 Commit 6da8cb1 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 11, 2023
@compiler-errors
Rollup merge of rust-lang#110165 - notriddle:notriddle/overscroll-beh…
a0a03e1 
…avior, r=GuillaumeGomez

rustdoc: use CSS `overscroll-behavior` instead of JavaScript

Fixes the desktop scrolling weirdness mentioned in rust-lang#98775 (comment)

Preview: https://notriddle.com/rustdoc-demo-html-3/overscroll-behavior/issue_107918/index.html

As described in the [MDN overscroll-behavior] page:

* The current Firefox ESR is 102, and the first Firefox version to support this feature is 59.
* The current Chrome version 112, and the first version to support this is 63.
* Edge is described as having a minor bug in `none` mode, but we use `contain` mode anyway, so it doesn't matter.
* Safari 16, released September 2022, is the last browser to add this feature, and is also the oldest version we officially support.

[MDN overscroll-behavior]: https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior
@compiler-errors compiler-errors mentioned this pull request Apr 11, 2023
Closed
@bors
Copy link
Collaborator

bors commented Apr 12, 2023

☔ The latest upstream changes (presumably #110194) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2023
@notriddle notriddle force-pushed the notriddle/overscroll-behavior branch from 6da8cb1 to 8340e1a Compare April 12, 2023 17:29
@notriddle

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 12, 2023
@notriddle
rustdoc: use CSS overscroll-behavior instead of JavaScript
bb7ed64 
Fixes the desktop scrolling weirdness mentioned in
rust-lang#98775 (comment)

As described in the MDN page for this property:

* The current Firefox ESR is 102, and the first Firefox version
  to support this feature is 59.
* The current Chrome version 112, and the first version to support
  this is 63.
* Edge is described as having a minor bug in `none` mode, but we
  use `contain` mode anyway, so it doesn't matter.
* Safari 16, released September 2022, is the last browser to
  add this feature, and is also the oldest version we officially
  support.
@notriddle notriddle force-pushed the notriddle/overscroll-behavior branch from 8340e1a to bb7ed64 Compare April 12, 2023 17:31
@rust-lang rust-lang deleted a comment from rustbot Apr 12, 2023
@notriddle
Copy link
Contributor Author

notriddle commented Apr 12, 2023

@rustbot review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2023
@notriddle notriddle removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2023
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 12, 2023

r=me once CI pass

@notriddle
Copy link
Contributor Author

notriddle commented Apr 12, 2023

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Apr 12, 2023

📌 Commit bb7ed64 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
@bors
Auto merge of rust-lang#110249 - matthiaskrgr:rollup-7iig04q, r=matth…
4087dea 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#110153 (Fix typos in compiler)
 - rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript)
 - rust-lang#110175 (Symbol cleanups)
 - rust-lang#110203 (Remove `..` from return type notation)
 - rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast)
 - rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro)
 - rust-lang#110237 (Split out a separate feature gate for impl trait in associated types)
 - rust-lang#110241 (tidy: Issue an error when UI test limits are too high)

Failed merges:

 - rust-lang#110218 (Remove `ToRegionVid`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 05e67b5 into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
@notriddle notriddle deleted the notriddle/overscroll-behavior branch April 12, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

4 participants

@notriddle @rustbot @GuillaumeGomez @bors